Clarify sandbox allowNetwork domain settings#314271
Merged
Merged
Conversation
Contributor
blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark

#### editor/codeEditor/CodeEditor/Light

#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark

#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light

#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark

#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing setting descriptions related to agent network domain filtering and the agent sandbox allowNetwork mode, and regenerates the corresponding enterprise policy catalog text so the messaging is clearer.
Changes:
- Reworded the terminal agent sandbox
allowNetworkenum description to state that all network domains are allowed. - Updated
chat.agent.allowedNetworkDomains/chat.agent.deniedNetworkDomainsdescriptions to mentionallowNetwork. - Updated generated enterprise policy text (
policyData.jsonc) to match the new setting descriptions.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts | Updates the allowNetwork enum description for the agent sandbox setting. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Updates the allowed/denied network domain setting descriptions to reference allowNetwork. |
| build/lib/policies/policyData.jsonc | Regenerated policy description strings to match the updated setting text. |
Copilot's findings
Comments suppressed due to low confidence (3)
src/vs/workbench/contrib/chat/browser/chat.contribution.ts:930
- Same issue in the policy-localized copy of the description:
allowNetworkdoes not bypass domain filtering whenchat.agent.networkFilteris enabled, so “all domains are allowed”/“denied takes precedence” should be made conditional to avoid being misleading.
value: nls.localize('chat.agent.allowedNetworkDomains', "Allowed domains for network access by agent tools (fetch tool, integrated browser). Applies when {0} or {1} is enabled. When {1} is set to {2}, all domains are allowed. Supports wildcards like {3}. When both allowed and denied lists are empty, all domains are blocked. Denied domains (see {4}) take precedence.", `\`#${AgentNetworkDomainSettingId.NetworkFilter}#\``, `\`#${AgentSandboxSettingId.AgentSandboxEnabled}#\``, `\`${AgentSandboxEnabledValue.AllowNetwork}\``, '`*.example.com`', `\`#${AgentNetworkDomainSettingId.DeniedNetworkDomains}#\``),
src/vs/workbench/contrib/chat/browser/chat.contribution.ts:936
- This says the denied domain list “does not apply” when
chat.agent.sandbox.enabledisallowNetwork, but the denied list still applies wheneverchat.agent.networkFilteris enabled (regardless of sandbox mode). Consider clarifying thatallowNetworkonly disables sandbox-driven filtering and does not affect the globalchat.agent.networkFilterbehavior.
markdownDescription: nls.localize('chat.agent.deniedNetworkDomains', "Denied domains for network access by agent tools (fetch tool, integrated browser). Applies when {0} or {1} is enabled. This does not apply when {1} is set to {2}. Takes precedence over {3}. Supports wildcards like {4}.", `\`#${AgentNetworkDomainSettingId.NetworkFilter}#\``, `\`#${AgentSandboxSettingId.AgentSandboxEnabled}#\``, `\`${AgentSandboxEnabledValue.AllowNetwork}\``, `\`#${AgentNetworkDomainSettingId.AllowedNetworkDomains}#\``, '`*.example.com`'),
src/vs/workbench/contrib/chat/browser/chat.contribution.ts:948
- Same issue in the policy-localized copy: the denied list still applies when
chat.agent.networkFilteris enabled, even ifchat.agent.sandbox.enabledisallowNetwork. The “does not apply” wording should be made conditional to avoid incorrect guidance.
value: nls.localize('chat.agent.deniedNetworkDomains', "Denied domains for network access by agent tools (fetch tool, integrated browser). Applies when {0} or {1} is enabled. This does not apply when {1} is set to {2}. Takes precedence over {3}. Supports wildcards like {4}.", `\`#${AgentNetworkDomainSettingId.NetworkFilter}#\``, `\`#${AgentSandboxSettingId.AgentSandboxEnabled}#\``, `\`${AgentSandboxEnabledValue.AllowNetwork}\``, `\`#${AgentNetworkDomainSettingId.AllowedNetworkDomains}#\``, '`*.example.com`'),
- Files reviewed: 3/3 changed files
- Comments generated: 1
pwang347
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #314181
This updates the setting descriptions for agent network domains and sandbox allowNetwork mode so they clearly state that allowNetwork allows all domains and denied network domains do not apply in that mode.