Fix 0/0 hover for ubb

[pwang347]

Fixes #314558

[github-actions]

Screenshot Changes

Base: c75215c0 Current: 46f8c065

Changed (9)

chat/input/chatInput/Default/Dark

Before	After

chat/input/chatInput/Default/Light

Before	After

chat/input/chatInput/WithFileChanges/Light

Before	After

chat/input/chatInput/WithTodos/Light

Before	After

chat/input/chatInput/WithTodosAndFileChanges/Dark

Before	After

chat/input/chatInput/WithArtifactsAndFileChanges/Dark

Before	After

chat/input/chatInput/WithArtifactsAndFileChanges/Light

Before	After

chat/widget/chatWidget/PendingToolApproval/Light

Before	After

chat/widget/chatWidget/MultiTurn/Light

Before	After

[Copilot]

Pull request overview

This PR addresses an incorrect quota hover display in the Chat Status dashboard where usage-based billing (UBB) quotas with entitlement: 0 could show a misleading 0 / 0 “credits used” fraction on hover.

Changes:

• Adds a regression test ensuring hover does not change the displayed quota value when entitlement is zero.
• Adjusts the dashboard hover behavior to avoid showing credit fractions when entitlement is falsy.

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/test/browser/chatStatusDashboard.test.ts	Adds a new test for the entitlement: 0 hover scenario to prevent 0 / 0 display regressions.
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts	Changes hover/focus “show credits” logic to skip credit fraction rendering when entitlement is falsy.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusDashboard.ts:716

• showCredits() now checks currentQuota.entitlement for truthiness. This makes the hover/focus display logic dependent on JS truthiness and means that when entitlement is 0 or undefined, showCredits() becomes a no-op. Because update() calls showCredits() whenever isHovered is true, quota updates that arrive while the element is hovered/focused will not refresh the displayed percentage/label. Consider using an explicit numeric check (e.g. typeof entitlement === 'number' && entitlement > 0) and falling back to showPercentage() when credits can't be shown so the UI still updates while hovered/focused.

		const showCredits = () => {
			if (typeof currentQuota !== 'string' && currentQuota.entitlement) {
				const total = currentQuota.entitlement;
				const used = total * (100 - currentQuota.percentRemaining) / 100;
				const usedFormatted = this.quotaCreditsFormatter.value.format(used);
				const totalFormatted = this.quotaCreditsFormatter.value.format(total);
				quotaValue.textContent = localize('quotaCreditsDisplay', "{0} / {1}", usedFormatted, totalFormatted);
				quotaValueSuffix.textContent = ` ${localize('quotaUsed', "used")}`;
			}
		};

• Files reviewed: 2/2 changed files
• Comments generated: 1