Force-close lingering connections in request test teardown by chrmarti · Pull Request #314657 · microsoft/vscode

chrmarti · 2026-05-06T07:29:39Z

Summary

Fixes a flaky Timeout of 30000ms exceeded failure in the "after each" hook for "cancel" of vs/base/parts/request/test/electron-main/request.test, observed on Linux CI.

The cancel and timeout tests open a request to a /noreply endpoint that the test server intentionally never responds to. After the client aborts/times out, the server-side socket can remain open when teardown runs, causing server.close() to wait until all connections drain — which never happens, and the hook hits the 30s mocha timeout.

Calling server.closeAllConnections() (Node 18.2+) before server.close() destroys those lingering sockets so close() resolves promptly.

Session Context

Diagnosis: The failure is in the after each hook for cancel, not the test body. server.close() keeps existing connections alive by design, so any socket from /noreply that hasn't fully torn down on the server side blocks teardown until the mocha timeout.
Fix scope: Limited to the test teardown. No production code changes; the request implementation is unaffected.
Why closeAllConnections(): Available since Node 18.2 (well within VS Code's supported range) and is the documented way to force in-flight server-side sockets closed.

Copilot

Pull request overview

Addresses a Linux CI flake in the Request electron-main tests where the /noreply endpoint can leave server-side sockets open, causing server.close() in teardown to hang until the Mocha hook timeout.

Changes:

Force-close any lingering HTTP connections in test teardown via server.closeAllConnections() before awaiting server.close().

Show a summary per file

File	Description
src/vs/base/parts/request/test/electron-main/request.test.ts	Ensures the test server teardown can’t hang on lingering sockets created by `/noreply` requests.