better handling of mounting/unmounting of aquarium#314659
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (12)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/NeedsInput/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents “developer joy” aquarium feature so it cleanly activates/deactivates based on the visibility of its hosting view, aiming to eliminate flicker during view swaps.
Changes:
- Extend
IAquariumService.mountToggle()to return a handle that can be informed of host visibility (setHostVisible). - Track per-mount host visibility and reconcile aquarium activation/deactivation accordingly (including a synchronous teardown path to avoid flashing).
- Wire the New Chat view pane visibility (
setVisible) into the aquarium toggle handle.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/chat/browser/newChatViewPane.ts |
Stores the mounted aquarium toggle handle and forwards view visibility changes via setHostVisible. |
src/vs/sessions/contrib/aquarium/browser/aquariumOverlay.ts |
Introduces IMountedToggleHandle, tracks mount visibility, and adds activation reconciliation + non-animated teardown support. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
dmitrivMS
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix flickering of developer joy feature cc JC from slack!