Conversation
…tegy The default has been AroundEditRange for a while; TopToBottom was kept only for backwards-compat experimentation. Drop the enum value, the code path that disabled focal ranges based on it, and the corresponding tests and docs section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (15)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Default/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifacts/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Full/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/MultiTurn/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/ApprovalRowLongLabel/Dark
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the NES/xtab “recently viewed files” clipping strategy surface by removing the legacy TopToBottom strategy and consolidating behavior around the remaining AroundEditRange and Proportional strategies.
Changes:
- Removed
TopToBottomfromRecentFileClippingStrategyand updated validators accordingly. - Simplified recent-snippet construction by always deriving focal ranges for edit entries and by removing the
clippingStrategyparameter from the greedy builder path. - Removed the
TopToBottomsnapshot coverage and updated the clipping-strategies specification doc to reflect only two strategies.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/inlineEdits/common/dataTypes/xtabPromptOptions.ts | Removes TopToBottom enum value and updates validators to accept only remaining strategies. |
| extensions/copilot/src/extension/xtab/common/recentFilesForPrompt.ts | Simplifies snippet creation/building by dropping TopToBottom branching and using focal ranges for edits unconditionally. |
| extensions/copilot/src/extension/xtab/test/common/recentFilesForPrompt.snapshots.spec.ts | Removes snapshot suites that validated TopToBottom behavior. |
| extensions/copilot/src/extension/xtab/common/recentFilesForPrompt.md | Updates spec to document only AroundEditRange and Proportional, and adjusts comparison table. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
alexr00
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default has been
AroundEditRangefor a while;TopToBottomwas kept only for backwards-compat experimentation. This PR drops:TopToBottomenum value fromRecentFileClippingStrategy(and from both validators)recentFilesForPrompt.tsthat disabled focal ranges based on this strategy (historyEntryToCodeSnippetandbuildCodeSnippetsGreedyare simplified — the latter no longer takes aclippingStrategyparameter and just falls back to top-of-file clipping when a file has no focal ranges)recentFilesForPrompt.snapshots.spec.tsrecentFilesForPrompt.mdVerification
tsc --noEmitpasses fortsconfig.json,tsconfig.worker.json, and the simulation workbenchtsconfig.jsonvitest --runforrecentFilesForPrompt.{spec,snapshots.spec}.ts— 52 / 52 tests passTopToBottom/topToBottomreferences in the copilot extension