show keybinding for search#314709
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents window search contribution to surface the Search command in menus in a way that should display its keybinding (Ctrl/Cmd+Shift+F) in the UI.
Changes:
- Replaced a sessions-specific
Action2(“openSearch”) with directMenuRegistry.appendMenuItementries pointing atsearch.action.openEditor. - Updated the View Title and View menubar entries to use
OpenEditorCommandIdso the keybinding can be shown.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/search/browser/search.contribution.ts | Rewires the Search menu items in the sessions UI to point directly at search.action.openEditor instead of a sessions wrapper action. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/sessions/contrib/search/browser/search.contribution.ts:45
- Same concern as the ViewTitle item: switching the menubar command id to
search.action.openEditorwill execute that command without the expected argument object. This risks a runtime error (or passing an unintended context argument) when the menu item is used. Safer is to keep a sessions-specific wrapper command and assign the desired keybinding to that command id.
MenuRegistry.appendMenuItem(MenuId.MenubarViewMenu, {
command: {
id: OpenEditorCommandId,
title: localize({ key: 'miSearch', comment: ['&& denotes a mnemonic'] }, "&&Search"),
},
- Files reviewed: 1/1 changed files
- Comments generated: 1
benibenj
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.