Skip to content

show keybinding for search#314709

Merged
sandy081 merged 1 commit into
mainfrom
sandy081/patient-orca
May 6, 2026
Merged

show keybinding for search#314709
sandy081 merged 1 commit into
mainfrom
sandy081/patient-orca

Conversation

@sandy081
Copy link
Copy Markdown
Member

@sandy081 sandy081 commented May 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2026 11:47
@sandy081 sandy081 enabled auto-merge (squash) May 6, 2026 11:47
@sandy081 sandy081 self-assigned this May 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Agents window search contribution to surface the Search command in menus in a way that should display its keybinding (Ctrl/Cmd+Shift+F) in the UI.

Changes:

  • Replaced a sessions-specific Action2 (“openSearch”) with direct MenuRegistry.appendMenuItem entries pointing at search.action.openEditor.
  • Updated the View Title and View menubar entries to use OpenEditorCommandId so the keybinding can be shown.
Show a summary per file
File Description
src/vs/sessions/contrib/search/browser/search.contribution.ts Rewires the Search menu items in the sessions UI to point directly at search.action.openEditor instead of a sessions wrapper action.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/search/browser/search.contribution.ts:45

  • Same concern as the ViewTitle item: switching the menubar command id to search.action.openEditor will execute that command without the expected argument object. This risks a runtime error (or passing an unintended context argument) when the menu item is used. Safer is to keep a sessions-specific wrapper command and assign the desired keybinding to that command id.
MenuRegistry.appendMenuItem(MenuId.MenubarViewMenu, {
	command: {
		id: OpenEditorCommandId,
		title: localize({ key: 'miSearch', comment: ['&& denotes a mnemonic'] }, "&&Search"),
	},
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/vs/sessions/contrib/search/browser/search.contribution.ts
@sandy081 sandy081 merged commit ea600e7 into main May 6, 2026
30 checks passed
@sandy081 sandy081 deleted the sandy081/patient-orca branch May 6, 2026 13:34
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants