Don't skip quota bucket when hasQuota: false#314874
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts chat quota snapshot parsing so that quota buckets are not dropped solely because has_quota is false (notably under token-based billing), while still filtering out buckets that represent “no allocated credits” (e.g. entitlement: 0 and not unlimited). This keeps quota UI/telemetry behavior aligned with the service’s snapshot semantics.
Changes:
- Update
parseQuotasto no longer skip snapshots based onhas_quota === false, and instead skip only non-unlimitedsnapshots withentitlement === 0. - Add/adjust unit tests to cover keeping TBB snapshots with
has_quota: falseand skipping zero-entitlement non-unlimited snapshots.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/chat/common/chatEntitlementService.ts | Changes quota snapshot filtering logic to avoid dropping buckets purely due to has_quota: false. |
| src/vs/workbench/contrib/chat/test/common/chatEntitlementService.test.ts | Adds coverage for the new filtering behavior and updates fixtures/assertions accordingly. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
bryanchen-d
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #314238