feat: wait for pending background tasks after SDK send in CopilotCLISession#314954
Merged
DonJayamanne merged 1 commit intoMay 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Copilot CLI chat session request flow to optionally wait for any pending SDK background tasks after _sdkSession.send() completes, improving post-send cleanup/synchronization without affecting the main request success path.
Changes:
- Import
LocalSessionfrom@github/copilot/sdkfor access to the optional background-task waiting API. - After
send(), callwaitForPendingBackgroundTasks()when available, and swallow/log errors so they don’t fail the main request.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSession.ts | After sending a request via the SDK session, optionally waits for pending background tasks (with error logging but no flow failure). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
Screenshot ChangesBase: Errored (20)Fixtures that failed to render — no screenshot was produced.
|
alexr00
approved these changes
May 7, 2026
DonJayamanne
deleted the
don/copilot/update-send-request-with-background-tasks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
_sdkSession.send()completes, wait for any pending background tasks viaLocalSession.waitForPendingBackgroundTasks()(if available).Errors from waiting on background tasks are caught and logged but do not fail the main request flow.
Changes
copilotcliSession.ts: AddedLocalSessionto SDK imports; addedwaitForPendingBackgroundTaskscall aftersend(), wrapped in try/catchCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com