Skip to content

Disable unsupported built-in extensions in sessions window#314978

Merged
benibenj merged 1 commit into
mainfrom
benibenj/fast-aphid
May 7, 2026
Merged

Disable unsupported built-in extensions in sessions window#314978
benibenj merged 1 commit into
mainfrom
benibenj/fast-aphid

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

@benibenj benibenj commented May 7, 2026

Copilot Generated Description: Disable built-in extensions that contribute unsupported features in the sessions window, specifically excluding the chat extension.

Copilot AI review requested due to automatic review settings May 7, 2026 10:42
@benibenj benibenj enabled auto-merge May 7, 2026 10:42
@benibenj benibenj self-assigned this May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts extension enablement behavior for the Sessions window so that built-in extensions contributing unsupported UI/features are disabled, while keeping the built-in chat extension enabled.

Changes:

  • Updates Sessions-window enablement logic to treat built-in extensions differently from non-built-ins.
  • Disables built-in extensions that contribute debuggers, views, view containers, or walkthroughs, with an explicit exemption for the chat extension.
Show a summary per file
File Description
src/vs/workbench/services/extensionManagement/browser/extensionEnablementService.ts Refines Sessions-window extension disablement rules for built-in extensions, exempting chat and disabling certain unsupported contribution types.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 3

Comment on lines +641 to +645
// Built-in extensions are enabled in sessions window except the chat extension and extensions that contribute not supported features.
if (extension.isBuiltin) {
if (extension.identifier.id.toLowerCase() === this._chatExtensionId) {
return false;
}
Comment on lines +641 to 652
// Built-in extensions are enabled in sessions window except the chat extension and extensions that contribute not supported features.
if (extension.isBuiltin) {
if (extension.identifier.id.toLowerCase() === this._chatExtensionId) {
return false;
}

const contributes = extension.manifest.contributes;
if (contributes?.debuggers || contributes?.views || contributes?.viewsContainers || contributes?.walkthroughs) {
return true;
}

return false;
Comment on lines 642 to +650
if (extension.isBuiltin) {
if (extension.identifier.id.toLowerCase() === this._chatExtensionId) {
return false;
}

const contributes = extension.manifest.contributes;
if (contributes?.debuggers || contributes?.views || contributes?.viewsContainers || contributes?.walkthroughs) {
return true;
}
@benibenj benibenj merged commit 07ef5b6 into main May 7, 2026
29 of 30 checks passed
@benibenj benibenj deleted the benibenj/fast-aphid branch May 7, 2026 10:59
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants