Agents - cleanup Changes view menus/actions#315014
Merged
Merged
Conversation
deepak1556
previously approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Agents window “Changes” view menu/action wiring by introducing dedicated menu IDs and extension menu keys for the Agents Changes toolbar, instead of reusing the Chat Editing session menus.
Changes:
- Added new extension-contributed menu keys for the Agents Changes toolbar and its primary-action submenu (
agents/changes/actions,agents/changes/actions/primary). - Migrated Agents-window “Changes” toolbar actions to the new
MenuId.AgentsChangesToolbar. - Updated built-in extension menu contributions to target the new menu key.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/actions/common/menusExtensionPoint.ts | Removes old apply-actions menu key and registers new Agents Changes toolbar + primary submenu keys. |
| src/vs/sessions/test/e2e/extensions/sessions-e2e-mock/package.json | Updates mock extension menu contributions to the new Agents Changes primary submenu key. |
| src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts | Moves session actions (mark done/restore) to the Agents Changes toolbar menu. |
| src/vs/sessions/contrib/codeReview/browser/codeReview.contributions.ts | Moves “Run Code Review” action contribution to the Agents Changes toolbar. |
| src/vs/sessions/contrib/changes/browser/changesViewActions.ts | Moves “Open Pull Request” action contribution to the Agents Changes toolbar. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Renders the Changes view button bar from MenuId.AgentsChangesToolbar. |
| src/vs/sessions/contrib/applyCommitsToParentRepo/browser/applyChangesToParentRepo.ts | Rewires the toolbar submenu entry to the new Agents Changes primary-action submenu. |
| src/vs/sessions/contrib/agentHost/test/browser/agentHostSkillButtons.test.ts | Adjusts test wiring to look at the Agents Changes toolbar (but still needs submenu ID updates). |
| src/vs/platform/actions/common/actions.ts | Removes the old submenu MenuId and adds new Agents Changes toolbar/submenu MenuIds. |
| extensions/github/package.json | Updates contributed menu key to the new Agents Changes primary submenu key. |
| extensions/copilot/package.json | Updates contributed menu key to the new Agents Changes primary submenu key. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 3
Comment on lines
167
to
171
| // Register the apply submenu in the session changes toolbar | ||
| MenuRegistry.appendMenuItem(MenuId.ChatEditingSessionChangesToolbar, { | ||
| submenu: MenuId.ChatEditingSessionApplySubmenu, | ||
| MenuRegistry.appendMenuItem(MenuId.AgentsChangesToolbar, { | ||
| submenu: MenuId.AgentsChangesPrimaryActionSubMenu, | ||
| title: localize2('applyActions', 'Apply Actions'), | ||
| group: 'navigation', |
sandy081
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.