Skip to content

Add right click visibility toggle for sign in button#315022

Merged
cwebster-99 merged 2 commits into
mainfrom
different-landfowl
May 8, 2026
Merged

Add right click visibility toggle for sign in button#315022
cwebster-99 merged 2 commits into
mainfrom
different-landfowl

Conversation

@cwebster-99
Copy link
Copy Markdown
Member

@cwebster-99 cwebster-99 commented May 7, 2026

Adds right click toggle for Sign in button to align with other elements in the title bar. Currently this can be hidden by signing in or disabling AI features so we want to support right click hide / show as well

image

Configuration and UI improvements:

  • Added new configuration option chat.titleBar.signIn.enabled to control whether the Copilot "Sign In" button appears in the title bar or falls back to the status bar when disabled. [1] [2]
  • Introduced ToggleSignInTitleBarAction, which allows users to toggle the visibility of the title bar sign-in button via the command palette. [1] [2] [3]
  • Updated the context expression for displaying the title bar sign-in button to respect the new configuration setting.
  • Enhanced the status bar entry logic to only show the "Sign In" label if the title bar affordance is not visible, ensuring consistent and context-aware UI. [1] [2] [3] [4] [5]
  • Implemented the isSignInTitleBarAffordanceVisible method to centralize the logic for determining when the title bar sign-in button should be shown, considering web context, workspace settings, Zen mode, and the new configuration.

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 7, 2026 14:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable right-click toggle for the Copilot “Sign In” title bar button, aligning it with other title bar context menu visibility controls and ensuring the status bar presentation stays consistent when the title bar affordance is hidden.

Changes:

  • Introduces a new setting, chat.titleBar.signIn.enabled, to control whether the signed-out “Sign In” affordance appears in the title bar or falls back to the status bar.
  • Adds a title bar context menu toggle action (ToggleSignInTitleBarAction) for that setting, and updates the title bar “Sign In” action’s visibility condition to respect it.
  • Updates the Copilot status bar entry to hide the “Sign In” label when the title bar affordance is visible and to react to relevant context/config changes.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/constants.ts Adds a new ChatConfiguration enum entry for the title bar sign-in visibility setting.
src/vs/workbench/contrib/chat/browser/chatStatus/chatStatusEntry.ts Updates status bar “Sign In” label logic and adds centralized visibility computation based on context/config.
src/vs/workbench/contrib/chat/browser/chatSetup/chatSetupContributions.ts Adds a title bar context menu toggle action and gates title bar “Sign In” button visibility by the new setting.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Registers the new configuration setting and its description/default.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

if (isWeb) {
return false;
}

Comment on lines +109 to +113
this._register(this.contextKeyService.onDidChangeContext(e => {
if (e.affectsSome(new Set(['updateTitleBar', InEditorZenModeContext.key]))) {
this.update();
}
}));
@cwebster-99 cwebster-99 marked this pull request as ready for review May 8, 2026 15:39
@cwebster-99 cwebster-99 merged commit 7aefe37 into main May 8, 2026
25 checks passed
@cwebster-99 cwebster-99 deleted the different-landfowl branch May 8, 2026 16:18
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Sign In" button next to Command Center (asking me to 'Use AI Features') - I am signed in but I use my own AI features

3 participants