Agents - improve the changes observable so that it does not fire too often#315031
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces unnecessary reactive updates in the Agents (sessions) UI by adding a structural equality comparer for session file-change arrays and wiring it into changes observables. This fits into the vs/sessions layer by improving how session providers publish file-change updates without triggering redundant downstream renders/derivations.
Changes:
- Added
sessionFileChangesEqualto perform structural equality checks for arrays ofISessionFileChange. - Updated Copilot chat sessions provider observables to use
observableValueOpts(..., { equalsFn })forchanges. - Updated agent-host sessions provider observables to use
observableValueOpts(..., { equalsFn })forchanges.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/services/sessions/common/session.ts | Introduces a reusable structural equality function for session file-change arrays using URI-aware comparisons. |
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts | Applies the new equality comparer to changes observables to suppress redundant notifications when republishing equivalent arrays. |
| src/vs/sessions/contrib/agentHost/browser/baseAgentHostSessionsProvider.ts | Applies the new equality comparer to agent-host-backed session changes observables to reduce update churn. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
sandy081
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.