Skip to content

Remove Agents app testing from sanity tests#315180

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/fix-sanity-tests
May 8, 2026
Merged

Remove Agents app testing from sanity tests#315180
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/fix-sanity-tests

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

Removes all Agents window/app testing from the release sanity tests.

Drops the testAgentsApp helper in test/sanity/src/desktop.test.ts and all 13 call sites across the desktop sanity scenarios (darwin, dmg, win32 system/user/archive).

Copilot AI review requested due to automatic review settings May 8, 2026 05:51
@dmitrivMS dmitrivMS enabled auto-merge (squash) May 8, 2026 05:52
@dmitrivMS dmitrivMS self-assigned this May 8, 2026
@dmitrivMS dmitrivMS added the engineering VS Code - Build / issue tracking / etc. label May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes coverage of the separate “Agents” window/app from the release sanity test suite, keeping the desktop sanity scenarios focused on validating the main VS Code desktop app across platforms and packaging formats.

Changes:

  • Removed all testAgentsApp(...) invocations across the desktop sanity scenarios (macOS, Linux, Windows; installers and archives).
  • Deleted the testAgentsApp helper function that launched VS Code with --agents and performed basic UI validation.
Show a summary per file
File Description
test/sanity/src/desktop.test.ts Removes Agents-app launch/validation from all desktop sanity scenarios and deletes the associated helper.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@dmitrivMS dmitrivMS merged commit c15ec12 into main May 8, 2026
30 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/fix-sanity-tests branch May 8, 2026 06:15
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering VS Code - Build / issue tracking / etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants