Agents - show label of the running action + progress icon#315200
Merged
Agents - show label of the running action + progress icon#315200
Conversation
benibenj
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Agents window “Changes” view toolbar to better reflect when git operations are running by showing a progress/loading icon and the label of the currently running action.
Changes:
- Add observable-driven button labels (
customLabelObs) and exposeonWillRun/onDidRunfromWorkbenchButtonBar. - Track the last-run action label in the Changes view and display it with a loading icon while a git operation is in progress.
- Add CSS tweaks to align the loading icon and text in the primary action button.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/browser/media/changesView.css | Styles for the primary action button layout when an icon is embedded in the label. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Tracks the running action label and switches commit/sync actions to a loading-label presentation during git operations. |
| src/vs/platform/actions/browser/buttonbar.ts | Adds observable label support and exposes action runner lifecycle events for consumers like the Changes view. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 4
Comment on lines
+373
to
+376
|
|
||
| .codicon { | ||
| margin: 0; | ||
| } |
Comment on lines
+135
to
+140
| const config = configProvider(action, i); | ||
| const showLabel = config?.showLabel ?? true; | ||
| const showIcon = config?.showIcon; | ||
| const customClass = config?.customClass; | ||
| const customLabel = config?.customLabel; | ||
| const customLabelObs = config?.customLabelObs; |
Comment on lines
+181
to
+186
| if (customLabelObs) { | ||
| this._updateStore.add(autorun(reader => { | ||
| const v = customLabelObs.read(reader); | ||
| applyLabel(v ?? customLabel ?? action.label); | ||
| })); | ||
| } |
Comment on lines
+182
to
+185
| // Set the running label override | ||
| reader.store.add(buttonBar.onWillRun(e => runningLabelObs.set(e.action.label, undefined))); | ||
|
|
||
| reader.store.add(buttonBar); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.