Skip to content

Allow more extensions to be enabled in the sessions window#315232

Merged
benibenj merged 1 commit into
mainfrom
benibenj/strategic-salmon
May 8, 2026
Merged

Allow more extensions to be enabled in the sessions window#315232
benibenj merged 1 commit into
mainfrom
benibenj/strategic-salmon

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

@benibenj benibenj commented May 8, 2026

Copilot Generated Description: Introduce a set of allowed extensions that can run in the sessions window, overriding the default environment checks.

Copilot AI review requested due to automatic review settings May 8, 2026 10:46
@benibenj benibenj enabled auto-merge May 8, 2026 10:46
@benibenj benibenj self-assigned this May 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit allow-list of extension IDs that should remain enabled in the sessions (Agents) window, overriding the default sessions-window environment disablement logic.

Changes:

  • Introduces SESSIONS_WINDOW_ALLOWED_EXTENSIONS, a hard-coded allow-list of extension IDs for the sessions window.
  • Updates ExtensionEnablementService to bypass sessions-window disablement for allow-listed extensions.
Show a summary per file
File Description
src/vs/workbench/services/extensionManagement/browser/sessionsWindowAllowedExtensions.ts Adds a new allow-list set of extension IDs intended to stay enabled in the sessions window.
src/vs/workbench/services/extensionManagement/browser/extensionEnablementService.ts Skips sessions-window disablement when an extension’s ID is in the new allow-list.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/workbench/services/extensionManagement/browser/extensionEnablementService.ts:645

  • New sessions-window allow-list behavior isn’t covered by a unit test. Please add a test in extensionEnablementService.test.ts that creates an extension whose id is in SESSIONS_WINDOW_ALLOWED_EXTENSIONS and would otherwise be DisabledByEnvironment (e.g. has main or unsupported contributions), and assert it remains enabled when isSessionsWindow is true.
		// Allow-listed extensions are always enabled in the sessions window.
		if (SESSIONS_WINDOW_ALLOWED_EXTENSIONS.has(extension.identifier.id.toLowerCase())) {
			return false;
		}
  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment on lines +642 to +644
// Allow-listed extensions are always enabled in the sessions window.
if (SESSIONS_WINDOW_ALLOWED_EXTENSIONS.has(extension.identifier.id.toLowerCase())) {
return false;
Comment on lines +11 to +22
'pkief.material-icon-theme',
'zhuangtongfa.material-theme',
'vscode-icons-team.vscode-icons',
'oderwat.indent-rainbow',
'formulahendry.auto-close-tag',
'pranaygp.vscode-css-peek',
'codezombiech.gitignore',
'usernamehw.errorlens',
'wayou.vscode-todo-highlight',
'bierner.markdown-mermaid',
'kisstkondoros.vscode-gutter-preview',
'tomoki1207.pdf',
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Screenshot Changes

Base: b482e070 Current: 9e08625c

Changed (4)

chat/chatToolRiskBadge/GreenElicitationInContext/Dark
Before After
before after
chat/chatToolRiskBadge/GreenElicitationInContext/Light
Before After
before after
chat/chatToolRiskBadge/OrangeElicitationInContext/Light
Before After
before after
chat/chatToolRiskBadge/RedElicitationInContext/Dark
Before After
before after

@benibenj benibenj merged commit efad736 into main May 8, 2026
30 checks passed
@benibenj benibenj deleted the benibenj/strategic-salmon branch May 8, 2026 11:04
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 8, 2026
lszomoru pushed a commit that referenced this pull request May 8, 2026
Allow more extensions to be enabled in the sessions window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants