Allow more extensions to be enabled in the sessions window#315232
Merged
Conversation
chrmarti
approved these changes
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit allow-list of extension IDs that should remain enabled in the sessions (Agents) window, overriding the default sessions-window environment disablement logic.
Changes:
- Introduces
SESSIONS_WINDOW_ALLOWED_EXTENSIONS, a hard-coded allow-list of extension IDs for the sessions window. - Updates
ExtensionEnablementServiceto bypass sessions-window disablement for allow-listed extensions.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/extensionManagement/browser/sessionsWindowAllowedExtensions.ts | Adds a new allow-list set of extension IDs intended to stay enabled in the sessions window. |
| src/vs/workbench/services/extensionManagement/browser/extensionEnablementService.ts | Skips sessions-window disablement when an extension’s ID is in the new allow-list. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/services/extensionManagement/browser/extensionEnablementService.ts:645
- New sessions-window allow-list behavior isn’t covered by a unit test. Please add a test in
extensionEnablementService.test.tsthat creates an extension whose id is inSESSIONS_WINDOW_ALLOWED_EXTENSIONSand would otherwise beDisabledByEnvironment(e.g. hasmainor unsupported contributions), and assert it remains enabled whenisSessionsWindowis true.
// Allow-listed extensions are always enabled in the sessions window.
if (SESSIONS_WINDOW_ALLOWED_EXTENSIONS.has(extension.identifier.id.toLowerCase())) {
return false;
}
- Files reviewed: 2/2 changed files
- Comments generated: 2
Comment on lines
+642
to
+644
| // Allow-listed extensions are always enabled in the sessions window. | ||
| if (SESSIONS_WINDOW_ALLOWED_EXTENSIONS.has(extension.identifier.id.toLowerCase())) { | ||
| return false; |
Comment on lines
+11
to
+22
| 'pkief.material-icon-theme', | ||
| 'zhuangtongfa.material-theme', | ||
| 'vscode-icons-team.vscode-icons', | ||
| 'oderwat.indent-rainbow', | ||
| 'formulahendry.auto-close-tag', | ||
| 'pranaygp.vscode-css-peek', | ||
| 'codezombiech.gitignore', | ||
| 'usernamehw.errorlens', | ||
| 'wayou.vscode-todo-highlight', | ||
| 'bierner.markdown-mermaid', | ||
| 'kisstkondoros.vscode-gutter-preview', | ||
| 'tomoki1207.pdf', |
Contributor
Screenshot ChangesBase: Changed (4) |
lszomoru
pushed a commit
that referenced
this pull request
May 8, 2026
Allow more extensions to be enabled in the sessions window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Introduce a set of allowed extensions that can run in the sessions window, overriding the default environment checks.