chat: don't recommend agent plugins when none are in the marketplace cache#315349
Merged
Conversation
…cache The 'this workspace recommends N agent plugins' notification fired whenever the workspace listed any enabledPlugins, even if none of those keys matched a plugin in lastFetchedPlugins. Clicking 'Show Plugins' then opened '@agentplugins @recommended' with an empty list. Filter the recommended count to keys that are actually present in the cached marketplace results so the notification only appears when the resulting view will have entries. Fixes #315347
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the chat “workspace recommends agent plugins” notification so it only appears when the subsequent @agentPlugins @recommended view is expected to contain entries, addressing the spurious notification reported in #315347.
Changes:
- Build a set of “known” marketplace plugin keys from cached marketplace results.
- Count only recommended plugin keys that are both uninstalled and present in the cached marketplace set before showing the notification.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/claudePluginRecommendations.ts | Filters the recommendation notification count using cached marketplace plugin keys to avoid leading users to an empty recommended list. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Per Copilot review on PR #315349: lastFetchedPlugins is empty until fetchMarketplacePlugins() runs, so fresh sessions with valid recommendations would never notify. Trigger a fetch when the cache is empty before deciding whether to show the notification. Also fix unrelated TS error in chatInputNotificationService.ts where active.message (string | IMarkdownString) was passed to status(string).
connor4312
previously approved these changes
May 8, 2026
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
…recs-empty # Conflicts: # src/vs/workbench/contrib/chat/browser/widget/input/chatInputNotificationService.ts Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Contributor
connor4312
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'this workspace recommends N agent plugins' notification fired whenever the workspace listed any
enabledPlugins, even if none of those keys matched a plugin inlastFetchedPlugins. Clicking Show Plugins then opened@agentPlugins @recommendedwith an empty list.Filter the recommended count to keys that are actually present in the cached marketplace results so the notification only appears when the resulting view will have entries.