Agents - fix edge cases for primary action in the Changes view#315389
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the Agents window “Changes” view decides which primary actions to surface by introducing a new sessions.hasBranchChanges context key and updating action when clauses to better handle cases where git state and session-provided change lists don’t align.
Changes:
- Add
sessions.hasBranchChangescontext key and plumb it from the Changes view model into the view’s scoped context. - Update “Mark as Done” visibility logic to distinguish “no changes” vs. merge/PR-completed states.
- Update Copilot extension primary-action menu gating for “Create PR” / “Create Draft PR” to use
sessions.hasBranchChanges.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts | Refines “Mark as Done” action visibility based on branch-change presence and merge/PR state. |
| src/vs/sessions/contrib/changes/common/changes.ts | Adds new ActiveSessionContextKeys.HasBranchChanges context key. |
| src/vs/sessions/contrib/changes/browser/changesViewModel.ts | Computes hasBranchChanges as part of active session state. |
| src/vs/sessions/contrib/changes/browser/changesView.ts | Binds/updates the new HasBranchChanges context key in the scoped Changes view context. |
| extensions/copilot/package.json | Switches Copilot CLI “Create PR” menu when clauses to depend on sessions.hasBranchChanges. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 2
Contributor
blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
 |
dmitrivMS
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.