Skip to content

Bump @vscode/gulp-electron to 1.41.3 (retry transient network errors)#315558

Merged
dmitrivMS merged 4 commits into
mainfrom
dev/dmitriv/build-fix-electron-download-retry
May 13, 2026
Merged

Bump @vscode/gulp-electron to 1.41.3 (retry transient network errors)#315558
dmitrivMS merged 4 commits into
mainfrom
dev/dmitriv/build-fix-electron-download-retry

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

@dmitrivMS dmitrivMS commented May 10, 2026

What

Bumps @vscode/gulp-electron from 1.41.2 to 1.41.3.

Why

1.41.3 brings in microsoft/vscode-gulp-electron#42 which adds retry-with-backoff around the three network operations involved in downloading Electron (the got HEAD on the release asset, getDownloadUrl, and @electron/get's downloadArtifact).

This fixes build breaks caused by transient DNS/network blips like:

[15:29:24] 'vscode-win32-x64-min-ci' errored after 17 s
[15:29:24] RequestError: getaddrinfo ENOTFOUND release-assets.githubusercontent.com

Observed on Insider build 437760, and likely the cause of similar one-off Windows build failures over the past months.

Brings in microsoft/vscode-gulp-electron#42 which adds retry-with-backoff
around transient network errors when downloading Electron, fixing build
breaks like getaddrinfo ENOTFOUND release-assets.githubusercontent.com.

NOTE: package-lock.json will be regenerated once 1.41.3 is published.
Do not merge until then.
Copilot AI review requested due to automatic review settings May 10, 2026 18:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the build-time dependency @vscode/gulp-electron to pick up improved resilience (retry/backoff) when downloading Electron artifacts, reducing CI failures from transient network/DNS issues.

Changes:

  • Update @vscode/gulp-electron from 1.41.2 to 1.41.3 in package.json.
Show a summary per file
File Description
package.json Bumps @vscode/gulp-electron to 1.41.3 to incorporate retry/backoff for Electron download network operations.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread package.json
dmitrivMS

This comment was marked as off-topic.

dmitrivMS

This comment was marked as off-topic.

dmitrivMS

This comment was marked as off-topic.

@dmitrivMS dmitrivMS added vscode-build VS Code build process issues engineering VS Code - Build / issue tracking / etc. labels May 12, 2026
@dmitrivMS dmitrivMS marked this pull request as ready for review May 12, 2026 23:36
@dmitrivMS dmitrivMS merged commit bddbcf2 into main May 13, 2026
25 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/build-fix-electron-download-retry branch May 13, 2026 02:33
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering VS Code - Build / issue tracking / etc. vscode-build VS Code build process issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants