Optimize agent mode instructions handling for efficiency#316152
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to optimize Copilot CLI chat history reconstruction by reducing per-turn agent mode-instructions resolution work when rebuilding stored request metadata for a session.
Changes:
- Replaces per-request agent/mode-instructions resolution with a single
defaultModeInstructionsvalue. - Adds inline comments explaining the intent to avoid resolving agents for older requests.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts | Simplifies mode-instructions selection while building the request-details lookup for history reconstruction. |
Copilot's findings
Comments suppressed due to low confidence (1)
extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts:1054
- Grammar: “Agents from older requests isn't useful” should be “aren't useful”. Also consider rewording the comment to accurately reflect the behavior (the code currently applies
defaultModeInstructions, not necessarily a “custom agent from last request”).
// Agents from older requests isn't useful, hence to save time.
// Re-use the same custom agent from last request for all previous requests.
- Files reviewed: 1/1 changed files
- Comments generated: 2
Contributor
Screenshot ChangesBase: Changed (24) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dmitrivMS
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.