Wait longer to get settings in _developer.getConfigurationInformation#316249
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the internal _developer.getConfigurationInformation command to more reliably wait for newly enabled built-in extensions to be registered (so their configuration contributions are included in the dumped settings), and increases the waiting timeout.
Changes:
- Replace the single
onDidChangeExtensions-event wait with tracking for all extensions being enabled to appear in the extension registry. - Increase the registration wait timeout from 5s to 15s.
- Use
ExtensionIdentifierSetto track pending extension registrations case-insensitively.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/preferences/browser/preferencesActions.ts |
Improves extension-registration waiting logic used by _developer.getConfigurationInformation when enabling disabled built-in extensions. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
|
aeschli
approved these changes
May 13, 2026
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
May 13, 2026
…n` (microsoft#316249) * Wait longer to get settings in `_developer.getConfigurationInformation` * CCR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.