Update context keys for editor commands#316261
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts command/menu enablement conditions (context keys) to prevent certain actions from being available in contexts where they shouldn’t apply (modal editor parts and auxiliary windows).
Changes:
- Gate the “Enable Preview Editors” editor title action so it does not appear when the editor part is in modal mode.
- Tighten the precondition for opening the Agents window by additionally requiring the command to be invoked from a non-auxiliary window.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/constants.ts |
Updates OPEN_AGENTS_WINDOW_PRECONDITION to also exclude auxiliary windows. |
src/vs/workbench/browser/parts/editor/editor.contribution.ts |
Adds a when clause to hide the preview toggle action in modal editor parts. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
208
to
+213
| export const OPEN_AGENTS_WINDOW_PRECONDITION = ContextKeyExpr.and( | ||
| ChatEntitlementContextKeys.Setup.hidden.negate(), | ||
| ChatEntitlementContextKeys.Setup.disabledInWorkspace.negate(), | ||
| IsSessionsWindowContext.negate(), | ||
| ContextKeyExpr.has(`config.${ChatConfiguration.AgentEnabled}`), | ||
| IsAuxiliaryWindowContext.negate() |
mjbvz
approved these changes
May 13, 2026
NikolaRHristov
pushed a commit
to CodeEditorLand/Editor
that referenced
this pull request
May 13, 2026
…donkey Update context keys for editor commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Update context keys for various editor commands to ensure they are not applicable to modal editors.