Sets virtual clock to a fixed date#316484
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes component fixture virtual time deterministic by seeding the VirtualClock with a fixed timestamp instead of the current real time.
Changes:
- Replaces
Date.now()as the virtual clock seed with a fixed UTC date. - Adds explanatory comments describing why deterministic wall-clock time matters for screenshot stability.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts |
Seeds component fixture virtual time from a fixed timestamp to reduce time-based screenshot drift. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Yoyokrazy
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.