Skip to content

Only generate copilot ThirdPartyNotices when publishing or releasing#316650

Merged
benvillalobos merged 4 commits into
microsoft:mainfrom
benvillalobos:ben/copilot-notice-publish-only
May 15, 2026
Merged

Only generate copilot ThirdPartyNotices when publishing or releasing#316650
benvillalobos merged 4 commits into
microsoft:mainfrom
benvillalobos:ben/copilot-notice-publish-only

Conversation

@benvillalobos
Copy link
Copy Markdown
Member

@benvillalobos benvillalobos commented May 15, 2026

Quick win for https://vscodeteam.slack.com/archives/C1Y427SES/p1778478238390869

Gates the Generate NOTICE file step in build/azure-pipelines/product-copilot.yml so it only runs when VSCODE_PUBLISH or VSCODE_RELEASE is true, matching the conditional pattern used in product-quality-checks.yml.

No downstream step requires ThirdPartyNotices.txt:

  • vsce package uses !ThirdPartyNotices.txt in .vscodeignore, which only un-ignores the file if present (no failure if absent).
  • No other step in the pipeline reads it.

Side effect: copilot VSIXs produced by non-publishing CI runs will not contain ThirdPartyNotices.txt. Publishing/release builds are unchanged.

Copilot AI review requested due to automatic review settings May 15, 2026 17:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR narrows Copilot NOTICE generation in the product build pipeline so it is skipped for non-publishing CI runs.

Changes:

  • Adds a runtime condition to the Copilot notice@0 step.
  • Intended to run NOTICE generation only when publishing or releasing.
Show a summary per file
File Description
build/azure-pipelines/product-copilot.yml Adds a condition to the Generate NOTICE file task.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread build/azure-pipelines/product-copilot.yml Outdated
@benvillalobos benvillalobos marked this pull request as ready for review May 15, 2026 17:38
@benvillalobos benvillalobos marked this pull request as draft May 15, 2026 17:38
@benvillalobos benvillalobos requested a review from Copilot May 15, 2026 17:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new

@benvillalobos benvillalobos marked this pull request as ready for review May 15, 2026 17:58
@benvillalobos benvillalobos enabled auto-merge (squash) May 15, 2026 17:58
@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering Bot commented May 15, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/product-build.yml
  • build/azure-pipelines/product-copilot.yml

@benvillalobos benvillalobos merged commit 217664a into microsoft:main May 15, 2026
25 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants