Skip to content

Stop injecting root install dir into PATH on Windows#316745

Merged
dmitrivMS merged 1 commit into
mainfrom
dev/dmitriv/fix-path-injection
May 16, 2026
Merged

Stop injecting root install dir into PATH on Windows#316745
dmitrivMS merged 1 commit into
mainfrom
dev/dmitriv/fix-path-injection

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

@dmitrivMS dmitrivMS commented May 16, 2026

Fixes #300231
Fixes #299416
Fixes #299523
Fixes #299598
Fixes #299703
Fixes #302026
Fixes #303020
Fixes #303021
Fixes #304350
Fixes #304797
Fixes #308193
Fixes #309315
Fixes #309316
Fixes #311267
Fixes #300307
Fixes #311187
Fixes #301050
Fixes #312434
Fixes #299962

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 16, 2026 04:10
@dmitrivMS dmitrivMS self-assigned this May 16, 2026
@dmitrivMS dmitrivMS added install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels May 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows installer registry entries so VS Code no longer injects the root installation directory into launched process PATH via App Paths.

Changes:

  • Keeps the App Paths default executable registration for Explorer/Run resolution.
  • Deletes the previously written App Paths Path value to avoid environment pollution.
Show a summary per file
File Description
build/win32/code.iss Updates Windows installer registry handling for the VS Code App Paths entry.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@dmitrivMS
Copy link
Copy Markdown
Contributor Author

@dmitrivMS
Copy link
Copy Markdown
Contributor Author

Verified:
image

@dmitrivMS dmitrivMS marked this pull request as ready for review May 16, 2026 05:48
@dmitrivMS dmitrivMS requested a review from deepak1556 May 16, 2026 05:48
@dmitrivMS dmitrivMS enabled auto-merge (squash) May 16, 2026 05:49
@dmitrivMS dmitrivMS disabled auto-merge May 16, 2026 05:49
@dmitrivMS dmitrivMS enabled auto-merge (squash) May 16, 2026 05:50
@dmitrivMS dmitrivMS removed the request for review from deepak1556 May 16, 2026 07:03
@dmitrivMS dmitrivMS merged commit 88562e7 into main May 16, 2026
56 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/fix-path-injection branch May 16, 2026 15:20
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment