build: increase mac signature verification timeout#317208
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Increases the Azure Pipelines task timeout for the macOS "Verify signature" step to reduce flaky failures where the signed app startup smoke check completes near the prior timeout boundary.
Changes:
- Bump per-arch macOS verify-signature timeout from 3 to 5 minutes.
- Bump universal macOS verify-signature timeout from 2 to 5 minutes.
Show a summary per file
| File | Description |
|---|---|
| build/azure-pipelines/darwin/steps/product-build-darwin-compile.yml | Increases timeoutInMinutes from 3 to 5 for the arch build verify-signature step. |
| build/azure-pipelines/darwin/product-build-darwin-universal.yml | Increases timeoutInMinutes from 2 to 5 for the universal verify-signature step. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
rzhao271
approved these changes
May 19, 2026
Collaborator
|
Thanks! I was bumping this already in #316661, x64 runs via rosetta hence the slowdown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Build 440250 failed in the macOS (X64) Verify signature step because the signed app startup smoke check completed just as the Azure Pipelines task hit its timeout. The codesign output showed a valid Developer ID signature and a stapled notarization ticket, and the app eventually wrote startup timers, so this gives the smoke check more room without changing the verification behavior.
Validation