Skip to content

[OSS Tool] Fix OSS license errors in cglicenses.json#317212

Merged
benvillalobos merged 2 commits into
release/1.121from
oss-license-fixes-1121-edfaeb067af6574b
May 19, 2026
Merged

[OSS Tool] Fix OSS license errors in cglicenses.json#317212
benvillalobos merged 2 commits into
release/1.121from
oss-license-fixes-1121-edfaeb067af6574b

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

OSS License Fixes

Fixes license errors from OSS tool run: https://github.com/microsoft/vscode-engineering/actions/runs/26066875560

Changes

Package Fix Type License Source Notes
@iconify-json/logos fullLicenseTextUri CC0-1.0 LICENSE.txt No repo URL in npm; icons are from gilbarbara/logos
@iconify-json/mdi fullLicenseTextUri Apache-2.0 LICENSE No repo URL in npm; icons from Templarian/MaterialDesign (Pictogrammers)
@internationalized/date fullLicenseTextUri Apache-2.0 LICENSE npm repo URL points to subdirectory; license at repo root
@nodelib/fs.stat fullLicenseTextUri MIT LICENSE npm repo URL points to subdirectory; license at repo root
@nodelib/fs.walk fullLicenseTextUri MIT LICENSE npm repo URL points to subdirectory; license at repo root
@nodelib/fs.scandir fullLicenseTextUri MIT LICENSE npm repo URL points to subdirectory; license at repo root
dlv prependLicenseText MIT README.md No LICENSE file; license referenced in README; copyright prepended for author Jason Miller

Next steps

After merging this PR, run the OSS tool workflow to regenerate ThirdPartyNotices.txt with the updated license data.

Generated by OSS Tool License Fixer · ● 1.7M ·

Add license entries for packages missing from OSS tool:
- @iconify-json/logos: CC0-1.0 from gilbarbara/logos
- @iconify-json/mdi: Apache-2.0 from Templarian/MaterialDesign
- @internationalized/date: Apache-2.0 from adobe/react-spectrum
- @nodelib/fs.stat, @nodelib/fs.walk, @nodelib/fs.scandir: MIT from nodelib/nodelib
- dlv: prepend copyright for Jason Miller (missing from README license link)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 18, 2026 23:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread cglicenses.json Outdated
// Author is Jason Miller (https://github.com/developit).
"name": "dlv",
"prependLicenseText": [
"Copyright (c) Jason Miller (https://jasonformat.com/)"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Don't use prependLicenseText here, instead use licenseDetail with this copyright statement

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — replaced prependLicenseText with licenseDetail containing the full MIT license text and the Copyright (c) Jason Miller (https://jasonformat.com/) statement in commit Fix dlv entry: use licenseDetail instead of prependLicenseText.

Co-authored-by: benvillalobos <4691428+benvillalobos@users.noreply.github.com>
Copilot AI requested a review from benvillalobos May 19, 2026 00:22
@benvillalobos benvillalobos marked this pull request as ready for review May 19, 2026 00:35
@benvillalobos benvillalobos merged commit 7d991ce into release/1.121 May 19, 2026
25 checks passed
@benvillalobos benvillalobos deleted the oss-license-fixes-1121-edfaeb067af6574b branch May 19, 2026 01:09
@vs-code-engineering vs-code-engineering Bot added this to the 1.121.0 milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants