build/darwin: skip @microsoft/mxc-sdk bin/ in Mach-O arch check#317865
Merged
Conversation
The @microsoft/mxc-sdk package ships per-arch native binaries under bin/arm64 and bin/x64 regardless of the host architecture, so the macOS x64 build was failing 'Verify arch of Mach-O objects' on node_modules/@microsoft/mxc-sdk/bin/arm64/mxc-exec-mac. Skip the whole bin/ tree, matching the pattern already used for similar multi-arch vendor payloads.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes macOS x64 build failures in the Mach-O architecture verification step by excluding @microsoft/mxc-sdk’s multi-architecture bin/ payload from validation. This aligns with existing exclusions for other vendor packages that ship multiple architectures side-by-side.
Changes:
- Skip
@microsoft/mxc-sdk/bin/**under bothnode_modulesandnode_modules.asar.unpackedin the Mach-O arch verification allowlist. - Add inline rationale explaining why the package is excluded (ships both arm64 and x64 regardless of host arch).
Show a summary per file
| File | Description |
|---|---|
| build/darwin/verify-macho.ts | Adds skip globs for @microsoft/mxc-sdk/bin/** to prevent false-positive arch mismatches on macOS x64 builds. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
dileepyavan
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing macOS x64 build introduced by #317669.
The
@microsoft/mxc-sdknpm package ships per-arch native binaries underbin/arm64andbin/x64regardless of host arch. The macOS x64 build failedVerify arch of Mach-O objectson:This blocked the unsigned x64 artifact, which then caused the universal stage to time out waiting for it (seen in insider build 441345).
Skip the whole
bin/tree inbuild/darwin/verify-macho.ts, matching existing patterns for other multi-arch vendor payloads (@github/copilot-darwin-*,@vscode/ripgrep-universal).Verified by:
@microsoft/mxc-sdk@0.2.0(bothbin/arm64andbin/x64).