sessions: scope navigation keybindings to non-editor focus#317986
Merged
Conversation
Add editorTextFocus.toNegated() to the when clause of Go Back and Go Forward keybindings so they work everywhere in the Agents window except when a text editor has focus, preventing conflicts with editor shortcuts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents window (“sessions” layer) navigation keybindings so Go Back / Go Forward only trigger when editor text is not focused, avoiding conflicts with editor-level cursor/navigation shortcuts.
Changes:
- Adds
EditorContextKeys.editorTextFocus.toNegated()to thewhenclause forsessions.goBack. - Adds
EditorContextKeys.editorTextFocus.toNegated()to thewhenclause forsessions.goForward. - Imports
EditorContextKeysto support the new keybinding context expression.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/sessions/browser/sessionsActions.ts | Scopes session back/forward keybindings to non-editor-text focus via EditorContextKeys.editorTextFocus negation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Comment on lines
129
to
134
| weight: KeybindingWeight.WorkbenchContrib, | ||
| win: { primary: KeyMod.Alt | KeyCode.LeftArrow }, | ||
| mac: { primary: KeyMod.WinCtrl | KeyCode.Minus }, | ||
| linux: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.Minus }, | ||
| when: IsSessionsWindowContext, | ||
| when: ContextKeyExpr.and(IsSessionsWindowContext, EditorContextKeys.editorTextFocus.toNegated()), | ||
| }, |
Comment on lines
169
to
174
| weight: KeybindingWeight.WorkbenchContrib, | ||
| win: { primary: KeyMod.Alt | KeyCode.RightArrow }, | ||
| mac: { primary: KeyMod.WinCtrl | KeyMod.Shift | KeyCode.Minus }, | ||
| linux: { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.Minus }, | ||
| when: IsSessionsWindowContext, | ||
| when: ContextKeyExpr.and(IsSessionsWindowContext, EditorContextKeys.editorTextFocus.toNegated()), | ||
| }, |
lszomoru
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
EditorContextKeys.editorTextFocus.toNegated()to thewhenclause of the Go Back and Go Forward session navigation keybindings.Problem
The session navigation keybindings (e.g., Alt+Left/Right on Windows) conflict with editor text navigation shortcuts when a text editor has focus in the Agents window.
Solution
The keybindings now require that the editor text is not focused, so they work everywhere in the Agents window (sidebar, chat area, etc.) but don't interfere with editor shortcuts like word navigation.