Skip to content

Fix Windows agent sandbox setting ID#318035

Merged
dileepyavan merged 1 commit into
mainfrom
DileepY/windowsSetting_fix
May 22, 2026
Merged

Fix Windows agent sandbox setting ID#318035
dileepyavan merged 1 commit into
mainfrom
DileepY/windowsSetting_fix

Conversation

@dileepyavan
Copy link
Copy Markdown
Member

@dileepyavan dileepyavan commented May 22, 2026

Fixes #318038

This updates AgentSandboxWindowsEnabled to use chat.agent.sandbox.enabledWindows instead of chat.agent.sandbox.enabled.windows.

Validation:

  • Precommit hygiene hook passed during commit

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Windows-specific agent sandbox setting identifier so it matches the intended configuration key name, ensuring the setting can be addressed consistently across the sandbox/agent-host plumbing.

Changes:

  • Rename AgentSandboxWindowsEnabled from chat.agent.sandbox.enabled.windows to chat.agent.sandbox.enabledWindows.
Show a summary per file
File Description
src/vs/platform/sandbox/common/settings.ts Updates the Windows agent sandbox setting ID constant to the corrected key name.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/vs/platform/sandbox/common/settings.ts
@dileepyavan dileepyavan enabled auto-merge (squash) May 22, 2026 19:40
@dileepyavan dileepyavan merged commit 1fdf66f into main May 22, 2026
26 checks passed
@dileepyavan dileepyavan deleted the DileepY/windowsSetting_fix branch May 22, 2026 19:41
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows agent sandbox setting uses incorrect ID

3 participants