Fixing build failures due to missing version info for MXC bin content#318144
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @dmitrivMSMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Broadens the VersionInfo validation path exclusion for MXC SDK so all files under node_modules/@microsoft/mxc-sdk/bin/ (not just .exe) are skipped, fixing sanity build failures caused by MXC bin content (e.g., .dll) lacking a ProductName VersionInfo resource.
Changes:
- Comment updated to refer broadly to "binaries under bin" instead of just Windows executables.
- Regex simplified to match any file path under MXC SDK
bin/, covering bothnode_modulesandnode_modules.asar.unpacked.
Show a summary per file
| File | Description |
|---|---|
| test/sanity/src/context.ts | Widen versionInfoPathExclude regex to skip all files under MXC SDK bin/ directory |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
alexdima
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.