Prevent signed-out users from seeing GitHub Copilot upgrade recommendations#318509
Merged
Conversation
…tries in model picker
vritant24
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat model picker so signed-out users do not receive Copilot control-manifest model entries, aligning model visibility with entitlement state.
Changes:
- Detects signed-out entitlement state in
ModelPickerWidget.show. - Uses an empty control-manifest model set for signed-out users while preserving free/paid manifest selection for signed-in users.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts |
Gates Copilot control-manifest entries based on ChatEntitlement.Unknown. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
dmitrivMS
previously approved these changes
May 27, 2026
…oid race with killForceful timer Co-authored-by: vritant24 <13074644+vritant24@users.noreply.github.com>
dmitrivMS
reviewed
May 27, 2026
…() to avoid race with killForceful timer" This reverts commit 0baa8cd.
dmitrivMS
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that signed-out users do not have access to Copilot control-manifest entries in the model picker. This change enhances user experience by restricting visibility based on user entitlement status.