ci: fix windows node_modules cache for pr pipeline#318558
Merged
Merged
Conversation
deepak1556
requested review from
TylerLeonhardt,
Yoyokrazy,
alexdima,
joaomoreno,
lszomoru and
rzhao271
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Windows node_modules cache generation workflow by explicitly running the root preinstall script before npm ci, aligning it with existing Windows CI patterns so Electron/v8 headers are prepared for native module builds.
Changes:
- Adds
node build/npm/preinstall.tsbefore the Windowsnpm ciretry loop. - Documents why the preinstall step is needed for Electron/v8 header patching.
lszomoru
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #316661
Refs https://github.com/microsoft/vscode/actions/runs/26512456376/job/78080171377