Fix language model event issues#319097
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ExtHostLanguageModels to avoid recursive model resolution when resolving language models whose identifiers are known but whose metadata is not present in the current extension host cache.
Changes:
- Replaces the retry path in
getLanguageModelByIdentifierwith a direct main-thread$selectChatModelscall. - Extracts
LanguageModelChatAPI object creation into_createLanguageModelChatApi. - Updates
selectLanguageModelsto create API objects directly and filter missing local entries.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/api/common/extHostLanguageModels.ts |
Refactors language model lookup/API object creation and changes selection behavior for models missing from the local ext-host cache. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Co-authored-by: Copilot <copilot@github.com>
vritant24
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318753
Fixes #318749 (recursion, not unsupported scenario)
Fixes https://github.com/microsoft/vscode-copilot-evaluation/issues/4075