Skip to content

Open in Agents Window should be hideable#319119

Merged
benibenj merged 1 commit into
mainfrom
benibenj/head-rooster
May 30, 2026
Merged

Open in Agents Window should be hideable#319119
benibenj merged 1 commit into
mainfrom
benibenj/head-rooster

Conversation

@benibenj

Copy link
Copy Markdown
Contributor

Copilot Generated Description: Introduce a configuration option to toggle the visibility of the "Open in Agents Window" button in the title bar. Add a new action to handle this toggle functionality.

closes #319104

Copilot AI review requested due to automatic review settings May 30, 2026 10:13
@benibenj benibenj enabled auto-merge May 30, 2026 10:13
@benibenj benibenj self-assigned this May 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a user-toggleable visibility control for the "Open in Agents Window" title-bar button, addressing issue #319104 where the button could be mistaken for the minimize button. The change introduces a new boolean configuration chat.titleBar.openInAgentsWindow.enabled (default true), gates the title-bar menu contribution on that setting, and registers a context-menu toggle action consistent with the existing Copilot Sign In title-bar toggle pattern.

Changes:

  • Add ChatConfiguration.TitleBarOpenInAgentsWindowEnabled enum entry and its boolean configuration registration (default true).
  • Gate OpenWorkspaceInAgentsWindowAction's MenuId.TitleBar contribution on the new setting.
  • Add and register ToggleOpenInAgentsWindowTitleBarAction extending the shared ToggleTitleBarConfigAction helper.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/constants.ts New ChatConfiguration enum member for the title-bar setting.
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts Registers the new boolean configuration with default true.
src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts Adds setting-based gate on the title-bar contribution and the new toggle action.
src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts Registers the new toggle action.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 0

@benibenj benibenj merged commit c29b1f9 into main May 30, 2026
26 checks passed
@benibenj benibenj deleted the benibenj/head-rooster branch May 30, 2026 10:43
@vs-code-engineering vs-code-engineering Bot added this to the 1.123.0 milestone May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More actions button is easily confused for minimize button

3 participants