sessions: use secondary button border for agent feedback Remove button#323363
Merged
Conversation
The Remove button in the agent feedback editor widget is a secondary button but used --vscode-button-border for its border, which inherits the themed/contrast (blue) border. Switch to the dedicated --vscode-button-secondaryBorder token so it renders as a subtle gray consistent with other secondary buttons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agents window’s agent feedback editor widget to use the dedicated secondary-button border theme token for the Remove button, ensuring it no longer inherits the primary/contrast (“blue”) border styling and instead matches standard secondary button appearance across VS Code.
Changes:
- Switch the Remove button’s border from
--vscode-button-border(with widget-border fallbacks) to--vscode-button-secondaryBorder.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts | Updates secondary button border styling to use the proper theme token for secondary buttons. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
sandy081
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Removebutton in the agent feedback editor widget is a secondary button (next to the primaryAcceptbutton). Its border was set to--vscode-button-border, which inherits the themed/contrast border and renders blue. This swaps it to the dedicated--vscode-button-secondaryBordertoken so it appears as a subtle gray, consistent with other secondary buttons across the UI.Why
A secondary button should not have a blue (primary/contrast) border.
--vscode-button-secondaryBorderis the purpose-built token for this (a ~15% transparent foreground gray in light/dark, contrast border in HC), keeping the widget consistent with the rest of VS Code.Notes for reviewers
agentFeedbackEditorWidgetContribution.ts.Acceptbutton styling is unchanged.