Skip to content

[cherry-pick] Hide new-session tours while a modal editor is visible#323487

Merged
benibenj merged 1 commit into
release/1.127from
cherry-pick/323479
Jun 29, 2026
Merged

[cherry-pick] Hide new-session tours while a modal editor is visible#323487
benibenj merged 1 commit into
release/1.127from
cherry-pick/323479

Conversation

@vs-code-engineering

Copy link
Copy Markdown
Contributor

Cherry-pick of #323479 from main.

Fixes #323453

Both new-session onboarding tours now gate their when condition on the modal editor not being visible. Combines the existing ChatContextKeys.enabled with EditorPartModalContext.toNegated() via ContextKeyExpr.and, so neither tour shows while a modal editor is open.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Copilot AI review requested due to automatic review settings June 29, 2026 13:07
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

@benibenj benibenj enabled auto-merge (squash) June 29, 2026 14:29
@benibenj benibenj merged commit 6c0dac6 into release/1.127 Jun 29, 2026
29 checks passed
@benibenj benibenj deleted the cherry-pick/323479 branch June 29, 2026 14:35
@vs-code-engineering vs-code-engineering Bot added this to the 1.127.0 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants