Skip to content

Add cwd to createTerminal via TerminalOptions for extension API Addresses: #37709#38132

Merged
Tyriar merged 2 commits intomicrosoft:masterfrom
cleidigh:terminal-api-cwd/add
Dec 15, 2017
Merged

Add cwd to createTerminal via TerminalOptions for extension API Addresses: #37709#38132
Tyriar merged 2 commits intomicrosoft:masterfrom
cleidigh:terminal-api-cwd/add

Conversation

@cleidigh
Copy link
Copy Markdown
Contributor

Adds an optional cwd argument to TerminalOptions for the extension API
to define the current working directory.

Addresses: #37709

Copy link
Copy Markdown

@rocketberg rocketberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@cleidigh cleidigh changed the title Add cwd to TerminalOptions for extension API Addresses: #37709 Add cwd to createTerminal via TerminalOptions for extension API Addresses: #37709 Nov 12, 2017
@Tyriar Tyriar merged commit 3560676 into microsoft:master Dec 15, 2017
@Tyriar
Copy link
Copy Markdown
Contributor

Tyriar commented Dec 15, 2017

Thanks @cleidigh!

@Tyriar Tyriar added this to the December 2017/January 2018 milestone Dec 15, 2017
@cleidigh cleidigh deleted the terminal-api-cwd/add branch December 20, 2017 21:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants