Skip to content

Mark onDidChangeActiveTextEditor can fire with undefined#39431

Merged
jrieken merged 1 commit intomicrosoft:masterfrom
mjbvz:onDidChangeActiveTextEditor-undefined
Dec 4, 2017
Merged

Mark onDidChangeActiveTextEditor can fire with undefined#39431
jrieken merged 1 commit intomicrosoft:masterfrom
mjbvz:onDidChangeActiveTextEditor-undefined

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Dec 1, 2017

From #39413

Bug
onDidChangeActiveTextEditor may fire with undefined for the editor. This is documented but not currently typed in the API

From microsoft#39413

**Bug**
onDidChangeActiveTextEditor may fire with undefined for the editor. This is not currently marked in the API
@mjbvz mjbvz requested review from bpasero and jrieken December 1, 2017 19:06
@mjbvz mjbvz self-assigned this Dec 1, 2017
@bpasero bpasero removed their request for review December 3, 2017 13:12
@jrieken
Copy link
Copy Markdown
Member

jrieken commented Dec 4, 2017

👍

@jrieken jrieken merged commit 5ecc577 into microsoft:master Dec 4, 2017
@alexdima alexdima added this to the November 2017 milestone Dec 8, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants