only dismiss editor context menu when scrollTop has changed#65111
Merged
sbatten merged 1 commit intomicrosoft:masterfrom Dec 19, 2018
sbatten:fix/54594
Merged
only dismiss editor context menu when scrollTop has changed#65111sbatten merged 1 commit intomicrosoft:masterfrom sbatten:fix/54594
sbatten merged 1 commit intomicrosoft:masterfrom
sbatten:fix/54594
Conversation
bpasero
approved these changes
Dec 17, 2018
alexdima
approved these changes
Dec 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #54594
This change is to prevent the context menu from dismissing when the scrollTop has not changed (e.g. when CodeLenses are loaded).
@rebornix and I think this should be a safe check as normal intentional scrolling should always move the scrollTop