Skip to content

Honor command enablement in keybindings#74672

Merged
jrieken merged 1 commit intomasterfrom
joh/fix74670
May 31, 2019
Merged

Honor command enablement in keybindings#74672
jrieken merged 1 commit intomasterfrom
joh/fix74670

Conversation

@jrieken
Copy link
Copy Markdown
Member

@jrieken jrieken commented May 31, 2019

This fixes #74670

@jrieken jrieken requested a review from sandy081 May 31, 2019 10:41
@jrieken jrieken self-assigned this May 31, 2019
@jrieken jrieken added this to the May 2019 milestone May 31, 2019
@sandy081
Copy link
Copy Markdown
Member

Changs look good to me. Also verified the fix.

Verified that a default keybinding for a command with enablement, has enablement expression in the when clause.

@jrieken jrieken merged commit acb1e2c into master May 31, 2019
@jrieken jrieken deleted the joh/fix74670 branch May 31, 2019 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command enablement not checked when assigning keybinding

2 participants