Update warning colors to pass color contrast ratio#75372
Merged
miguelsolorio merged 1 commit intomasterfrom Jun 13, 2019
Merged
Update warning colors to pass color contrast ratio#75372miguelsolorio merged 1 commit intomasterfrom
miguelsolorio merged 1 commit intomasterfrom
Conversation
sandy081
approved these changes
Jun 13, 2019
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a result of #74580 but updates the new warning colors so that it closer matches our input warning colors and also passes the color contrast ratio (had to tweak it a bit). This also updates
editorOverviewRuler.findMatchForegroundso that the colors don't blend too much with the warning color.In order for
list.warningForegroundto pass the cc ratio in the tree view I had to darken it a bit.cc @bpasero
Dark
Light