Skip to content

Fix #81890 - Fix HSLA to RGBA in color picker#82055

Merged
rebornix merged 2 commits intomicrosoft:masterfrom
NeeEoo:NeeEoo-patch-1
Oct 23, 2019
Merged

Fix #81890 - Fix HSLA to RGBA in color picker#82055
rebornix merged 2 commits intomicrosoft:masterfrom
NeeEoo:NeeEoo-patch-1

Conversation

@NeeEoo
Copy link
Contributor

@NeeEoo NeeEoo commented Oct 7, 2019

This fixes #81890

@NeeEoo NeeEoo changed the title Fixes #81890 Fix HSLA to RGBA in color picker. Fixes #81890 Oct 18, 2019
@NeeEoo NeeEoo changed the title Fix HSLA to RGBA in color picker. Fixes #81890 Fix #81890 - Fix HSLA to RGBA in color picker Oct 18, 2019
@rebornix
Copy link
Member

Thanks for your help. RGBA asks for integers while we are using Number as the parameter type, which doesn't protect us from passing a float.

@rebornix rebornix merged commit ec895a4 into microsoft:master Oct 23, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong HSL to RGB conversion when using the color picker

2 participants