Skip to content

EOL User Setting should be able to be set per language or file type#82101

Merged
aeschli merged 4 commits intomasterfrom
aeschli/eol_languagespecific
Oct 8, 2019
Merged

EOL User Setting should be able to be set per language or file type#82101
aeschli merged 4 commits intomasterfrom
aeschli/eol_languagespecific

Conversation

@aeschli
Copy link
Contributor

@aeschli aeschli commented Oct 8, 2019 •
edited
Loading

Fixes #49418. Fixes #34876

I tested that new files get the language specific settings.
#34876 (comment) seems to be no longer a problem.

@aeschli aeschli requested a review from bpasero October 8, 2019 12:49
@aeschli aeschli self-assigned this Oct 8, 2019
@aeschli aeschli changed the title Make files.eol overridable. Fixes #49418. Fixes #34876 EOL User Setting should be able to be set per language or file type Oct 8, 2019
@aeschli aeschli added this to the September 2019 milestone Oct 8, 2019
bpasero
bpasero approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeschli this would probably still not work correctly if someone started with an untitled file (which is always plain text) and then changes the mode later.

@aeschli
Copy link
Contributor Author

aeschli commented Oct 8, 2019

this would probably still not work correctly if someone started with an untitled file (which is always plain text) and then changes the mode later.

Pushed a fix for that (Consulting with @alexandrudima ): 7ba9113

@aeschli aeschli merged commit eaedd52 into master Oct 8, 2019
@aeschli aeschli deleted the aeschli/eol_languagespecific branch October 8, 2019 15:54
This was referenced Oct 8, 2019
Closed
Closed
@tschaub tschaub mentioned this pull request Nov 8, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bpasero bpasero bpasero approved these changes

@alexdima alexdima alexdima approved these changes

Assignees

@aeschli aeschli

Labels

None yet

Projects

None yet

Milestone

September 2019

Development

Successfully merging this pull request may close these issues.

[shellscript] use Unix eol by default EOL User Setting should be able to be set per language or file type.

3 participants

@aeschli @bpasero @alexdima