Skip to content

Add setting to configure the max memory for tsserver#82630

Merged
mjbvz merged 5 commits intomicrosoft:masterfrom
MLoughry:configure-tsserver-memory
Oct 15, 2019
Merged

Add setting to configure the max memory for tsserver#82630
mjbvz merged 5 commits intomicrosoft:masterfrom
MLoughry:configure-tsserver-memory

Conversation

@MLoughry
Copy link
Contributor

This PR fixes #33524 by adding a setting typescript.tsserver.maxTsServerMemory, which passes the setting on to tsserver using --max-old-space-size

Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 15, 2019

Thanks @MLoughry! Just want to confirm, using a high memory setting does fix the out of memory issues for you?

@MLoughry
Copy link
Contributor Author

@mjbvz Yes. tsserver still takes a while to spin up on our massive project, but it no longer crashes and "forgets" all the work it did when I configure a higher memory limit.

@mjbvz mjbvz merged commit 89e4d3e into microsoft:master Oct 15, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 15, 2019

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass max_old_space_size to TSServer

3 participants