Add setting to configure the max memory for tsserver#82630
Merged
mjbvz merged 5 commits intomicrosoft:masterfrom Oct 15, 2019
Merged
Add setting to configure the max memory for tsserver#82630mjbvz merged 5 commits intomicrosoft:masterfrom
mjbvz merged 5 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks @MLoughry! Just want to confirm, using a high memory setting does fix the out of memory issues for you? |
Contributor
Author
|
@mjbvz Yes. |
mjbvz
reviewed
Oct 15, 2019
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #33524 by adding a setting
typescript.tsserver.maxTsServerMemory, which passes the setting on totsserverusing--max-old-space-size