fixes #92857

[videlalvaro]

This PR fixes #92857

[aeschli]

Not sure. A dictionary is a set. We'll keep it as is.

[videlalvaro]

Bummer. I know this is a very low priority issue, but here's where I'm coming from

I was planning to write a blog post about how comments help with code understandability and wanted to use this case about an API that got improved thanks to a simple change.

Here's an article I wrote for the ACM explaining why I think this is important https://queue.acm.org/detail.cfm?id=3127495

And here I wrote about the importance of "paratexts" (as in Literary Theory) or code comments: https://dl.acm.org/doi/10.1145/3191697.3214326

From wikibooks:

Sets are groups of items, unordered with duplicates removed. The keys of a dictionary form a set, but each key has an associated value; these values could be duplicated within a dictionary.

I think calling that a set when we could either use dictionary or collection goes more aligned with what the code does, because set has a very specific and narrowing definition related to element uniqueness.

[aeschli]

Let's change it to 'dictionary'. I like that suggestion.

[videlalvaro]

Thanks.

Should we reopen this PR or go for a new one?

[videlalvaro]

@aeschli just updated the PR, thanks!

[aeschli]

Thanks @videlalvaro !