Allow multiple api acquire in notebook webview#93048
Merged
Conversation
mjbvz
approved these changes
Mar 19, 2020
| @@ -128,7 +128,7 @@ | |||
| * @param {*} [state] | |||
Collaborator
There was a problem hiding this comment.
[nit] Can you please add a jsdoc type as well
Member
Author
There was a problem hiding this comment.
yup, will add that first then merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notebook custom renderers live in the same webview so they already share the same messaging channel. To allow them send messages from the webview to the extension host, we can allow multiple api acquire. This feature is only turned on for Notebook.
We don't re-export
acquireVSCodeAPIas we want renderers extensions to use it in the same way as a normal webview.