Skip to content

Show a context menu item when not signed into any accounts#95391

Merged
sandy081 merged 2 commits intomasterfrom
rmacfarlane/noAccountsMenu
Apr 16, 2020
Merged

Show a context menu item when not signed into any accounts#95391
sandy081 merged 2 commits intomasterfrom
rmacfarlane/noAccountsMenu

Conversation

@RMacfarlane
Copy link
Copy Markdown
Contributor

@RMacfarlane RMacfarlane commented Apr 15, 2020

As per discussion, adds a context menu entry to the Accounts menu when there are no session across all auth providers

@RMacfarlane RMacfarlane self-assigned this Apr 15, 2020
@RMacfarlane RMacfarlane requested a review from sandy081 April 16, 2020 00:12
Copy link
Copy Markdown
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandy081 sandy081 merged commit a2745b1 into master Apr 16, 2020
@sandy081 sandy081 deleted the rmacfarlane/noAccountsMenu branch April 16, 2020 11:05
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants