Clean up search view dirty state#97038
Merged
JacksonKearl merged 3 commits intomasterfrom May 5, 2020
Merged
Conversation
added 3 commits
May 5, 2020 15:00
JacksonKearl
changed the title
roblourens
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #96851
Looking more into it, I think the search should be dirty any time any result has been removed, but only if the view still has items.
This also fixes a bug in the old fix whereby if you deleted a result then cleared all the results, the model would still be in the dirty state.
cc @roblourens reverted the commits from #96803