Always use canonical uri inside createModelReference#99658
Conversation
|
|
||
| async createModelReference(resource: URI): Promise<IReference<IResolvedTextEditorModel>> { | ||
|
|
||
| resource = this.uriIdentityService.asCanonicalUri(resource); |
There was a problem hiding this comment.
@bpasero this is the brute force way which might be OK... However, there are still all callers that we might need to visit and should maybe move this call to where it matter most, e.g where we actually branch off into the file service. E.g here:
All other places shouldn't be affected by URI "normalization" because only file systems can contribute rules.
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
@jrieken I only added a comment to explain the reasoning, this is a comment I also have in editor service to clear things up a bit.
We can move it closer to where we branch off into files, but on the other hand, that does not change things in anyway because since it only impacts resources with file providers anyway, we do not cause any harm for all other resources that are being passed in, right?
…solverService.ts Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
Yeah, no harm with that. Let's ship it and see how it works |
2 participants
This is for #93368