Feedback for b23229f
The textFileEditorModel is now restoring the backup in its load method as suggested. However you are passing in the etag and the encoding of the file model into the resolveContent method of the backup. This is problematic for two reasons:
- the
etag is used to find out if the file has been modified since but you take the wrong etag (from the file, not the backup)
- the encoding of the file model can be UTF-16 but I think all backups are stored as UTF-8?
Feedback for b23229f
The
textFileEditorModelis now restoring the backup in itsloadmethod as suggested. However you are passing in theetagand the encoding of the file model into theresolveContentmethod of the backup. This is problematic for two reasons:etagis used to find out if the file has been modified since but you take the wrongetag(from the file, not the backup)